Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 #2623

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 #2623

wants to merge 3 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 6, 2025

Which problem is this PR solving?

Short description of the changes

  • Drops support for AWS SDK for JavaScript v2

@trivikr trivikr requested a review from a team as a code owner January 6, 2025 22:45
@github-actions github-actions bot requested review from blumamir and jj22ee January 6, 2025 22:45
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (fcca38a) to head (18b31e6).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   90.95%   89.31%   -1.65%     
==========================================
  Files         172      172              
  Lines        8137     8046      -91     
  Branches     1649     1625      -24     
==========================================
- Hits         7401     7186     -215     
- Misses        736      860     +124
Files with missing lines Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 93.12% <ø> (-1.94%) ⬇️
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 93.10% <ø> (-4.20%) ⬇️

... and 5 files with indirect coverage changes

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 43d7ee6 to 07d9c02 Compare January 7, 2025 17:50
@trivikr

This comment was marked as outdated.

Sign in to view
@trivikr trivikr mentioned this pull request Jan 7, 2025
Closed
@trivikr trivikr changed the title chore(aws-sdk): drop support for AWS SDK for JavaScript v2 feat(aws-sdk): drop support for AWS SDK for JavaScript v2 Jan 7, 2025
@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 1e7dd92 to fd36945 Compare January 8, 2025 20:43
@trivikr

This comment was marked as outdated.

Sign in to view
@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from fd36945 to 74259dc Compare January 9, 2025 19:12
@trivikr trivikr mentioned this pull request Jan 10, 2025
Merged
@pichlermarc pichlermarc changed the title feat(aws-sdk): drop support for AWS SDK for JavaScript v2 feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 Jan 15, 2025
@pichlermarc
Copy link
Member

@trivikr I changed the title to include a ! to mark this PR as a breaking change so it shows up as such in the changelog.

Please update the branch if you find the time to see if the build failures have been resolved. I think the TAV failures are resolved by #2628 and #2643 🙂

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 74259dc to 293aec2 Compare January 15, 2025 16:32
@trivikr
Copy link
Contributor Author

trivikr commented Jan 15, 2025

Thank you @pichlermarc. I've rebased the changes.

The CI is failing though for the path which isn't updated

  1) MessageAttributes
       injectPropagationContext
         should inject context if there are available attributes:
     Error: expect(received).toBeGreaterThan(expected)

Test code which fails:

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-aws-sdk/test/MessageAttributes.test.ts

Line 84 in 6b4e532

expect(Object.keys(contextAttributes).length).toBeGreaterThan(5);

Execution https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/12792793464/job/35664659517?pr=2623

I confirmed when debugging that propagation.inject is called but it has not impact on the contents of attributes
Source code

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/MessageAttributes.ts

Line 81 in 6b4e532

propagation.inject(context.active(), attributes, contextSetter);

@blumamir @jj22ee Do you know what may be going wrong?

@trivikr trivikr mentioned this pull request Jan 15, 2025
Draft
pichlermarc
pichlermarc reviewed Jan 27, 2025
View reviewed changes
plugins/node/opentelemetry-instrumentation-aws-sdk/test/sns.test.ts
});
});

describe('SNS - v3', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it tested v3 - did you mean to delete these tests? 🤔

@pichlermarc
Copy link
Member

@trivikr oh, looks like the lint step is failing.
Running npm run lint:fix should take care of it, seems to be just some replacement from " to ' . 🙂

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from a1e15a1 to 18b31e6 Compare January 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc left review comments

@blumamir blumamir Awaiting requested review from blumamir

@jj22ee jj22ee Awaiting requested review from jj22ee

At least 1 approving review is required to merge this pull request.

Assignees

@trivikr trivikr

@blumamir blumamir

@jj22ee jj22ee

Labels
pkg:instrumentation-aws-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[instrumentation-aws-sdk] Drop support for JS SDK v2
4 participants
@trivikr @pichlermarc @blumamir @jj22ee